Developers Forum for XinFin XDC Network

Anshuman Chatterjee
Anshuman Chatterjee

Posted on • Updated on

[Suggestion] Increase the Tx Size to 128KB

As i can see the tx.size() is 32KB https://github.com/XinFinOrg/XDPoSChain/blob/b1677b0a21ad266d5c36d1e10c1a2e0530c2e5b0/core/tx_pool.go#L600

Can you please increase it to 128KB as per ETH go client https://github.com/ethereum/go-ethereum/blob/830f3c764c21f0d314ae0f7e60d6dd581dc540ce/core/txpool/legacypool/legacypool.go#L53

Attaching a PR that was closed which is related to this https://github.com/XinFinOrg/XDPoSChain/pull/283

Discussion (2)

Collapse
gzliudan profile image
Daniel Liu • Edited on

We had bump the tx size to 64KB in this PR. According to the report, there are some crash risk if we set it to 128KB before EIP-2464. My colleague is working on EIP-2464 now.

Collapse
wanwiset25 profile image
Wanwiset Peerapatanapokin • Edited on

Hi @anshuman_chatterjee_supra

Good point, we have discussed this on the weekly call and will look to implement this change. Thank you for raising the issue.